Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLPAB-1518 - enable lambda insights for image lambda #810

Merged
merged 15 commits into from
Nov 2, 2023
Merged

MLPAB-1518 - enable lambda insights for image lambda #810

merged 15 commits into from
Nov 2, 2023

Conversation

andrewpearce-digital
Copy link
Contributor

@andrewpearce-digital andrewpearce-digital commented Oct 30, 2023 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Oct 30, 2023 •
edited
Loading

PR Environment Terraform Plan Summary

Plan: 1 to add, 4 to change, 1 to destroy

@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@andrewpearce-digital andrewpearce-digital temporarily deployed to dev_810mlpab151 October 30, 2023 19:05 — with GitHub Actions Inactive
@andrewpearce-digital andrewpearce-digital temporarily deployed to dev_810mlpab151 October 31, 2023 09:13 — with GitHub Actions Inactive
@andrewpearce-digital andrewpearce-digital force-pushed the MLPAB-1518-how-to-get-lambda-insights-for-the-s-3-antivirus-lamdba-function branch from 4e266a6 to 33043fe Compare October 31, 2023 10:16
@andrewpearce-digital andrewpearce-digital temporarily deployed to dev_810mlpab151 October 31, 2023 11:06 — with GitHub Actions Inactive
@andrewpearce-digital andrewpearce-digital temporarily deployed to dev_810mlpab151 November 1, 2023 09:39 — with GitHub Actions Inactive
@andrewpearce-digital andrewpearce-digital temporarily deployed to dev_810mlpab151 November 1, 2023 12:37 — with GitHub Actions Inactive
@andrewpearce-digital andrewpearce-digital force-pushed the MLPAB-1518-how-to-get-lambda-insights-for-the-s-3-antivirus-lamdba-function branch from 8e93836 to f12e43f Compare November 1, 2023 14:30
@andrewpearce-digital andrewpearce-digital marked this pull request as ready for review November 1, 2023 14:44
@andrewpearce-digital andrewpearce-digital requested a review from a team as a code owner November 1, 2023 14:44
@andrewpearce-digital andrewpearce-digital temporarily deployed to dev_810mlpab151 November 1, 2023 15:04 — with GitHub Actions Inactive
@andrewpearce-digital andrewpearce-digital temporarily deployed to dev_810mlpab151 November 1, 2023 16:39 — with GitHub Actions Inactive
acsauk
acsauk reviewed Nov 1, 2023
View reviewed changes
docker/event-received/Dockerfile Outdated
@@ -20,6 +22,13 @@ ENTRYPOINT ["./event-received"]

FROM public.ecr.aws/lambda/provided:al2 AS production

# ARG arch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray comment?

acsauk
acsauk approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@acsauk acsauk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andrewpearce-digital andrewpearce-digital temporarily deployed to dev_810mlpab151 November 2, 2023 10:41 — with GitHub Actions Inactive
@andrewpearce-digital andrewpearce-digital merged commit 4298ebf into main Nov 2, 2023
24 checks passed
@andrewpearce-digital andrewpearce-digital deleted the MLPAB-1518-how-to-get-lambda-insights-for-the-s-3-antivirus-lamdba-function branch November 2, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acsauk acsauk acsauk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewpearce-digital @acsauk