feat/SSM-31: added context with timeout to avoid hanging requests. #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Change is to fix the timeout issue in the IngestHandler function within handler.go.
Approach
To fix the timeout issue, I added a
context.WithTimeout
call to set a timeout duration for the HTTP call to create a stub case in Sirius. This ensures that the HTTP call does not wait indefinitely for a response, and instead returns an error if the response takes longer than the specified timeout duration.Additionally, added the
cancel()
function to ensure that the context is cancelled when the function returns, but not before theCreateCaseStub
call has completed.Learning
Check my context usages properly!
Checklist