Feat/opg scanning poc #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 29, 2024 15:52
…dc php compoenents.
…rocessed jobs completed test with embedded callback.
ramchale
previously approved these changes
Oct 31, 2024
… code and refactoring.
added 6 commits
November 1, 2024 09:53
…tion, and slight refactor / clean-up of handler.go.
…support for both .env and yaml.
gregtyler
reviewed
Nov 4, 2024
…d comments / clean-up.
- Configure CodeQL for Go - Add Dockerfile - Run tests in pipeline
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…pression / refactor logger to use OPG.
…justice/opg-scanning into feat/opg-scanning-poc
… queue and update Dockerfile to ensure xsd docs are present.
Log in to ECR, then pull Trivy repositories from it. Use appropriate name for application ECR repository.
added 10 commits
November 6, 2024 11:36
…justice/opg-scanning into feat/opg-scanning-poc
…ed job_queue_test.go to load multiple xml files directly.
…ntation and test coverage for lp1f validator
…dlers for multi page instances
… for specific fields.
gregtyler
reviewed
Nov 14, 2024
added 2 commits
November 15, 2024 10:01
…ADME.md removal, dateparser updated, and re-organisation
…/ logger updated.
gregtyler
previously approved these changes
Nov 15, 2024
…dle case stub creation.
gregtyler
reviewed
Nov 15, 2024
gregtyler
force-pushed
the
feat/opg-scanning-poc
branch
from
d404faa to
6645984
Compare
This service doesn't run its own terraform
So the tests can be run without needing environment variables to be set
I missed some bits
gregtyler
force-pushed
the
feat/opg-scanning-poc
branch
from
19e9864 to
151f688
Compare
gregtyler
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Initial POC setup in order to prepare the skeleton code for the migration from DDC PHP module to Go
Approach
Based on the continued analysis of DDC module we are encapsulating relative handlers for the workflow processing of documents. For the time being the code will represent a high-level outline of how the process is foreseen in Go and is subject to change.
Learning
Good dig of DDC module source code, and the setup of the docker environment (on-going)
Checklist