Map 178 uof new header and footer #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. reverted css relating to contenr width because the Use of force reports' page needs a greater width to accommodate 4 tabs and a link. Have made the new headers the same width. 2. reverted crossOriginEmbedderPolicy to false as otherwise the date widget will not work. 3. Defined the digitalPrisonServiceUrldp var in nunjucks setup so that it could be accessed by the fallback header
GurnankCheema
commented
Sep 28, 2023
| @@ -91,7 +91,7 @@ export default function createApp(services: Services): Express { | |||
|
|
|||
| app.use( | |||
| helmet({ | |||
| crossOriginEmbedderPolicy: true, | |||
| crossOriginEmbedderPolicy: false, | |||
There was a problem hiding this comment.
needed for date-picker widget in new report page and Completed reports page
GurnankCheema
commented
Sep 28, 2023
| @@ -39,6 +39,7 @@ export default function configureNunjucks(app: Express.Application): nunjucks.En | |||
| njkEnv.addGlobal('authUrl', config.apis.oauth2.url) | |||
| njkEnv.addGlobal('apiClientId', config.apis.oauth2.apiClientId) | |||
| njkEnv.addGlobal('featureFlagOutageBannerEnabled', config.featureFlagOutageBannerEnabled) | |||
| njkEnv.addGlobal('digitalPrisonServiceUrl', config.apis.digitalPrisonServiceUrl) | |||
There was a problem hiding this comment.
needed by fallback header
GurnankCheema
commented
Sep 28, 2023
| @@ -1,5 +1,12 @@ | |||
| @import "palette" | |||
|
|
|||
| div.govuk-width-container | |||
There was a problem hiding this comment.
needs wider container width in Use of force incidents page
used 1170px instead of 1150px previously used so it's same as new header width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes follow the guidance here
The blue feedback block (which leads to Survey Monkey) above footer removed as new footer has a feedback link also going to Survey monkey
The /get-help page removed as the new footer has a phone number for application support
Useful info in these projects that have also implemented the new header/footer:
CVL
DPS