Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAP-577 New options for Prisoner Relocation #666

Merged
merged 8 commits into from
Jan 16, 2024

Conversation

danbenton-mojdt
Copy link
Contributor

No description provided.

GurnankCheema
GurnankCheema previously approved these changes Jan 16, 2024
Copy link
Contributor

@GurnankCheema GurnankCheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Outdated
@@ -29,8 +29,8 @@
"security_audit": "npx audit-ci --config audit-ci.json"
},
"engines": {
"node": "^18",
"npm": "<10"
"node": "^21",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we definitely want to use Node 21? Only even numbers are LTS versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - BaSM is on 21 too but that's arguably more actively developed. Happy to go with majority

@danbenton-mojdt danbenton-mojdt merged commit 8cc1c09 into main Jan 16, 2024
9 checks passed
@danbenton-mojdt danbenton-mojdt deleted the MAP-577-prisoner-relocation-new-options branch January 16, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants