Map 581 move question on body worn cameras to details screen #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GurnankCheema
commented
Jan 23, 2024
| @@ -39,27 +39,6 @@ const completeSchema = joi.object({ | |||
| 'NO', | |||
| 'NOT_KNOWN' | |||
| )('Select yes if any part of the incident captured on CCTV').alter(optionalForPartialValidation), | |||
|
|
|||
There was a problem hiding this comment.
this is input validation and has been moved to /useOfForceDetailsForm. ts
GurnankCheema
commented
Jan 23, 2024
| @@ -7,6 +7,8 @@ export type IncidentDetails = { | |||
|
|
|||
| export type UseOfForceDetails = { | |||
| positiveCommunication: boolean | |||
| bodyWornCamera?: string | |||
There was a problem hiding this comment.
temporarily made optional
GurnankCheema
commented
Jan 23, 2024
| @@ -195,105 +193,6 @@ <h1 class="govuk-heading-xl mainHeading">{{ pageTitle }} </h1> | |||
| }) | |||
| }} | |||
| </div> | |||
|
|
|||
| <!-- Q4 --> | |||
There was a problem hiding this comment.
this has moved to the useOfForceDetails.html
jimbali
reviewed
Jan 24, 2024
jimbali
approved these changes
Jan 25, 2024
jimbali
deleted the
MAP-581-UoF-move-question-on-body-worn-cameras-to-uof-details-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAP-581
Move the body-camera question out of the 'Evidence' page and put in 'Use of force details' page.
The code in the PR will put the body-worn camera responses for any new reports in the correct place of the DB blob. However old reports will still have the data within Evidence section of blob. The long term goal is to run a DB migration to shift the data and MAP-642 has been raised to do that work.
In the meantime I have implemented logic in the 4th commit of this PR to get the question response irrespective of which section it is in the blob.
And while I have annotated the question as optional, it is mandatory, and was done just to accommodate the fact that it could be in either evidence or details sections. And once Map-642 has been done, we can rip out the changes in the 4th commit