MAP-581 fix input field alignment #677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GurnankCheema
commented
Jan 27, 2024
| @@ -170,6 +82,80 @@ | |||
| {% endcall %} | |||
| {% endmacro%} | |||
|
|
|||
| {% macro radiosWithAddAnotherTextBox(question) %} | |||
There was a problem hiding this comment.
renamed macro and removed the Not known code as it is no longer needed
GurnankCheema
commented
Jan 27, 2024
| primaryQuestion:{ | ||
| text: "Was any part of the incident captured on a body-worn camera?", | ||
| name: "bodyWornCamera", | ||
| value: data.bodyWornCamera, | ||
| errorMessage: errors | findError('bodyWornCamera'), | ||
| includeNotKnown: false | ||
| questionSubject: 'body-worn-camera' |
There was a problem hiding this comment.
to use this for integration tests and panel that open when Yes is selected
GurnankCheema
commented
Jan 27, 2024
| @@ -1,2 +1 @@ | |||
| new AddAnother($('.add-another-evidence'), '.remove-button-container') | |||
| new AddAnother($('.add-another-input'), '.remove-button-container') | |||
There was a problem hiding this comment.
moved this into a new file that more represents the page it serves, i.e details page
|
this code has been included in map-625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes to remove the Not known option caused the input fields to go out of alignment and the No button to move down. like this:
Have fixed this and also refactored code so that macro is more generic and so can be used for other questions.
The question now looks like this
