Map 625 uof new weapons observed question #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GurnankCheema
commented
Jan 29, 2024
| @@ -214,6 +214,18 @@ | |||
| print: print | |||
| }) | |||
| }} | |||
|
|
|||
There was a problem hiding this comment.
the 'if' is needed for old reports that predate the weapons question
GurnankCheema
commented
Jan 29, 2024
| @@ -53,6 +52,27 @@ const completeSchema = joi.object({ | |||
|
|
|||
| pavaDrawn: requiredBooleanMsg('Select yes if PAVA was drawn').alter(optionalForPartialValidation), | |||
|
|
|||
There was a problem hiding this comment.
validation spec for the new weapons observed question
GurnankCheema
commented
Jan 29, 2024
| @@ -51,94 +51,6 @@ | |||
| </div> | |||
| {% endmacro %} | |||
|
|
|||
|
|
|||
| {% macro radioWithMultipleNestedTextBox(question) %} | |||
There was a problem hiding this comment.
this macro renamed and rewritten
GurnankCheema
commented
Jan 29, 2024
| @@ -394,7 +380,7 @@ | |||
| <div class="govuk-checkboxes__item"> | |||
| <input | |||
| class="govuk-checkboxes__input" | |||
| id="parent-{{option.value}}" | |||
There was a problem hiding this comment.
fix a label attribute clash
danbenton-mojdt
requested changes
Jan 29, 2024
2. reinstated Not Known for body-worn cameras 3. fixed label and input associations for checkboxesWithNestedCheckboxes macro as it was cauing label on one question to trigger input on another
fixed |
danbenton-mojdt
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new 'weapons observed' question to the report details page
The functionality for this is identical to the body-worn camera question. So the macro previously used for body-worn cameras has been adapted to make it reusable for both questions.