Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAP-1636 cron job recovery #720

Merged
merged 4 commits into from
Oct 1, 2024
Merged

MAP-1636 cron job recovery #720

merged 4 commits into from
Oct 1, 2024

Conversation

michalnawrockidj
Copy link
Contributor

No description provided.

danbenton-mojdt
danbenton-mojdt previously approved these changes Oct 1, 2024
View reviewed changes
GurnankCheema
GurnankCheema previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@GurnankCheema GurnankCheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimbali
Copy link
Contributor

jimbali commented Oct 1, 2024

I get this when I run helm template:

Error: template: use-of-force/templates/job.yaml:6:8: executing "use-of-force/templates/job.yaml" at <include "app.labels" .>: error calling include: template: no template "app.labels" associated with template "gotpl"

@jimbali
Copy link
Contributor

jimbali commented Oct 1, 2024

You can test generating the templates by running:

helm --debug template -f helm_deploy/values-dev.yaml helm_deploy/use-of-force

GurnankCheema
GurnankCheema approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@GurnankCheema GurnankCheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalnawrockidj michalnawrockidj merged commit a7b66d9 into main Oct 1, 2024
9 checks passed
@michalnawrockidj michalnawrockidj deleted the MAP-1636-v2 branch October 1, 2024 10:40
@marcusaleman
Copy link
Contributor

@michalnawrockidj MAP-1636 ticket is for BVL and the narrative is something different than this UOF Cron Job recovery https://dsdmoj.atlassian.net/browse/MAP-1636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GurnankCheema GurnankCheema GurnankCheema approved these changes

@danbenton-mojdt danbenton-mojdt danbenton-mojdt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michalnawrockidj @jimbali @marcusaleman @GurnankCheema @danbenton-mojdt