MAP-1625 enabling update of incidentDetails with incidentLocationId #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails Old UoF reports that currently store the locationId will also now store the incidentLocationId. The incidentLocationId is obtained from the nomis-sync-prisoner-mapping api. The only part of the report that will change is the form_response.incidentDetails Any reports that already have the incidentLocationId will not change.
GurnankCheema
commented
Oct 15, 2024
| } else if (locationId) { | ||
| const token = await this.systemToken(req.user.username) | ||
|
|
||
| const { dpsLocationId } = |
There was a problem hiding this comment.
L33 get the new location id from the locations-inside-prison-api that maps to the old nomis location id
GurnankCheema
commented
Oct 15, 2024
| const { dpsLocationId } = | ||
| await this.nomisMappingService.getDpsLocationDetailsHavingCorrespondingNomisLocationId(token, locationId) | ||
|
|
||
| report.form.incidentDetails.incidentLocationId = dpsLocationId |
There was a problem hiding this comment.
L36 add the new location id to the incidentDetails part of the report. No other parts of incidentDetails will change
GurnankCheema
commented
Oct 15, 2024
|
|
||
| const updatedSection = report.form.incidentDetails | ||
|
|
||
| await this.reportService.update(res.locals.user, reportId, 'incidentDetails', updatedSection) |
There was a problem hiding this comment.
L40 , the update function is existing functionality that is used for editing reports
GurnankCheema
commented
Oct 15, 2024
| const updatedSection = report.form.incidentDetails | ||
|
|
||
| await this.reportService.update(res.locals.user, reportId, 'incidentDetails', updatedSection) | ||
|
|
There was a problem hiding this comment.
I have started all the logs with the word 'Ad-hoc' just to be able to target them more easily
jnioche-jd
approved these changes
Oct 15, 2024
GurnankCheema
deleted the
MAP-1625-UOF-add-new-incident-location-id-to-existing-reports
branch
jnioche-jd
pushed a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change is to allow users to add the incidentLocationId to existing reports. The trigger for the action is by calling /update-location-id followed by /1/9, where 1 is the reportId id to start from and 9 the reportId to end on.
The incidentLocationId is obtained from the nomis-sync-prisoner-mapping api. The only part of the report that will change is the form_response.incidentDetails.
Any reports that already have the incidentLocationId will not change.
The actual update action in the database uses the already available functionality used when we edit reports.