Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAP-1937 move ttlSecondsAfterFinished to correct nest #745

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

GurnankCheema
Copy link
Contributor

@GurnankCheema GurnankCheema commented Dec 16, 2024

helm file format incorrect in last PR. Move ttlSecondsAfterFinished to pod spec section

Copy link

@BarryGee-MOJ BarryGee-MOJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GurnankCheema GurnankCheema merged commit 719b6c8 into main Dec 16, 2024
9 checks passed
@GurnankCheema GurnankCheema deleted the MAP-1937-UoF-cron-bug-fix-invalid-helm-file branch December 16, 2024 08:41
GurnankCheema added a commit that referenced this pull request Dec 16, 2024
GurnankCheema added a commit that referenced this pull request Dec 16, 2024
* Revert "MAP-1937 move ttlSecondsAfterFinished to correct nest (#745)"

This reverts commit 719b6c8.

* Revert "MAP-1937 give jobs longer time to complete.  (#744)"

This reverts commit d9c7fae.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants