Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (by removing) an outdated docblock type hint #166

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Nov 28, 2022

This is necessary to make Psalm checks pass at FriendsOfBehat/SymfonyExtension#195.

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #166 (5d3d2b2) into master (1852736) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     98.24%   98.24%           
  Complexity      113      113           
=========================================
  Files             1        1           
  Lines           285      285           
=========================================
  Hits            280      280           
  Misses            5        5           
Impacted Files Coverage Δ
src/BrowserKitDriver.php 98.24% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stof stof merged commit 9cfc13f into minkphp:master Nov 28, 2022
@mpdude mpdude deleted the patch-1 branch November 28, 2022 13:24
@mpdude
Copy link
Contributor Author

mpdude commented Dec 9, 2022

@stof do you think you could cut a bugfix release including this? I have a pending PR in one of the friends-of-Behat repos that cannot pass builds due to Psalm errors solved here.

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants