Add missing Math constants and functions #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdotdesign
added
enhancement
gdotdesign
approved these changes
Aug 26, 2023
core/source/Math.mint
Outdated
Comment on lines
3
to
10
| const E = `Math.E` | ||
| const LN10 = `Math.LN10` | ||
| const LN2 = `Math.LN2` | ||
| const LOG10E = `Math.LOG10E` | ||
| const LOG2E = `Math.LOG2E` | ||
| const PI = `Math.PI` | ||
| const SQRT12 = `Math.SQRT1_2` | ||
| const SQRT2 = `Math.SQRT2` |
There was a problem hiding this comment.
Would be nice if these constants have comments as well.
Sija
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to achieve 1:1 parity with the browser
MathAPIs