Add a summary of the signed transaction #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OBorce
requested review from
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
iljakuklic
approved these changes
Feb 1, 2024
|
I will change a few things and make transactions generally printable. I converted the PR to draft. |
iljakuklic
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
This looks good to me.
A nuclear option would be to generalise this with traits, roughly like this:
- Introduce a
Summarizetrait that has the same signature asstd::fmt::Displaybut takes an extrachain_configparameter - Introduce a wrapper type
Summary(T, &ChainConfig)which implementsDisplayifT: Summarize. It now works everywhere you can useDisplay. - There could be even extension trait that makes the syntax even more convenient, changing from
Summary(my_tx, &cc)tomy_tx.summary(&cc) - The summary trait could be implemented for outputs, inputs, transactions, or whatever else needs to be summarized
The above reuses all the formatting machinery already in Rust and would integrate rather nicely with existing tools, for exmaple:
log::debug!("Summary of transaction: {}", my_tx.summary(&cc))- same with
println!,format!,write!and such my_tx.summary(&cc).to_string()would work too
Comment on lines
+156
to
+160
| let s = match output { | ||
| TxOutput::Transfer(val, dest) => { | ||
| let val_str = fmt_val(val); | ||
| format!("Transfer({}, {val_str})", fmt_dest(dest)) | ||
| } |
There was a problem hiding this comment.
The output printout could be taken out to a separate function in case someone wants to print outputs separately. Similarly with inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print out a summary of the singed transaction form the wallet CLI