Remove inputting the mnemonic in command line arguments #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheQuantumPhysicist
requested review from
erubboli,
iljakuklic and
azarovh
as code owners
TheQuantumPhysicist
force-pushed
the
fix/remove-input-mnemonic-in-address-gen
branch
from
175f605
to
8dfb8c6
Compare
azarovh
approved these changes
Feb 6, 2024
TheQuantumPhysicist
deleted the
fix/remove-input-mnemonic-in-address-gen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This program should only be used for generating new mnemonics, not for inputting them. Besides, it's a security flaw because it encourages writing the mnemonics in command line arguments, which is a security risk due to them being saved in shell history.
If someone needs this functionality, they should use the cli wallet in cold mode.