tx-verifier: Introduce Context types #1750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These types hold information about the block and transaction being verified. The verification procedure interfaces with the context types rather than inspecting block / transaction directly.
iljakuklic
force-pushed
the
tx-verifier-fuse-checks
branch
from
3c5352f
to
f41a343
Compare
|
|
||
| pub struct BlockVerificationContext<'a> { | ||
| chain_config: &'a ChainConfig, | ||
| destination_getter: SignatureDestinationGetter<'a>, |
There was a problem hiding this comment.
Note that after introducing scripting, this will probably be eliminated. This is because SignatureDestinationGetter assumes that there's exactly one signature to verify per input, while in reality, it can be more complex than just that.
|
Done in #1762 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types hold information about the block and transaction being verified. The verification procedure interfaces with the context types rather than inspecting block / transaction directly.
Not quite happy with this yet, will evolve this further. Feedback welcome.