Reenable tokens in simulation tests #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovh
requested review from
erubboli,
iljakuklic and
TheQuantumPhysicist
as code owners
azarovh
force-pushed
the
fix/reenable_tokens_in_simulation_test
branch
from
4612e65
to
44199a7
Compare
TheQuantumPhysicist
approved these changes
May 15, 2024
OBorce
reviewed
May 15, 2024
OBorce
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RandomTxMakerused for simulation testsRandomTxMakerinstead of passing it around (which is confusing and had a bug)RandomTxMakerbut rather get them viaSignatureDestinationGetterafterwards. This simplifies the code and also fixes a bug in it.ApiServerInMemoryStorageaddress balance tables. The problem with previous data type is that it didn't consider the fact that fetching latest height balance might contain not all currencies. Note that new type is also not perfect because the removal "above height" is now linear which should be ok for tests.