Mempool rpc events #1807
Merged
Mempool rpc events #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
approved these changes
Sep 4, 2024
Comment on lines
+75
to
+79
| /// Subscribe to events emitted by mempool subsystem | ||
| fn subscribe_to_subsystem_events(&mut self, handler: Arc<dyn Fn(MempoolEvent) + Send + Sync>); | ||
|
|
||
| /// Subscribe to broadcast mempool events | ||
| fn subscribe_to_rpc_events(&mut self) -> utils_networking::broadcaster::Receiver<MempoolEvent>; |
There was a problem hiding this comment.
I don't think the naming is adequate here, because these 2 functions subscribe to exactly the same events, only the mechanism differ.
The names of the corresponsing methods of Mempool - subscribe_to_events and subscribe_to_event_broadcast - sound better.
(I'd still rename the latter though, e.g. to subscribe_to_events_via_broadcaster or something like that)
There was a problem hiding this comment.
Not sure. This is literally reverting changes from #1501. Though I agree that these events aren't subsystem's or rpc's. subscribe_to_events_subsystem?
OBorce
approved these changes
Sep 5, 2024
azarovh
force-pushed
the
feat/mempool_rpc_events
branch
from
e519c76
to
887c67e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to subscribe to mempool event over websocket