Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix task list for boefjes, normalizer and ooi detail #4115

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

Rieven
Copy link
Contributor

@Rieven Rieven commented Feb 20, 2025

Changes

Getting specific tasks for ooi detail, boefje detail and normalizer detail. The filtering by attributes did not work, so I have changed it using the filtering.

Issue link

#4095
#4106

Closes #4106

QA notes

Creatin different orgs with different tasks and see if task list of the one org is mixed with the other org.
Try also to create same ooi in different orgs to test that it also filters for org when the ooi is the same.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Rieven Rieven requested a review from a team as a code owner February 20, 2025 10:53
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@underdarknl underdarknl merged commit 48d1d75 into main Feb 20, 2025
22 checks passed
@underdarknl underdarknl deleted the fix/task-list-detail-pages branch February 20, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all boefjes where shown on ooi_detail page regardless of enabled state.
3 participants