This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
Custom challenge implementation with unit tests and refactor #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, we could also create the original pull request for the unit tests and refactoring here and merge that first. That would lower the amount of changes. |
That would make the review a lot easier. I don't care that much about the tests and refactor for the sake of a PoC. |
gerbrand-bosch
previously approved these changes
Nov 21, 2024
Co-authored-by: gerbrand-bosch <[email protected]>
…vws/nl-uzi-acme-ca-server into feature/implemented-custom-challenge
gerbrand-bosch
approved these changes
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of this pull request on the original repository, a custom challenge was implemented too. For this, an JWT is passed through the challenge endpoint.