Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yubikey doesn't get reset on creating the RSA keys #49

Closed
basvandriel opened this issue Dec 11, 2024 · 1 comment · Fixed by #54
Closed

Yubikey doesn't get reset on creating the RSA keys #49

basvandriel opened this issue Dec 11, 2024 · 1 comment · Fixed by #54
Assignees

Comments

@basvandriel
Copy link
Contributor

In the CreateRSAKeysPage page, where the RSA keys are being created on the Yubikey, the key doesn't get reset. The following code is being called however, but not every user has the ykman tool installed.

ykman piv reset --force

This issue also relates to #48. Do we still want to input the user PIN after the reset?

@basvandriel
Copy link
Contributor Author

Discussed in todays daily standup with @ScrumServices @ricklambrechts and @aliodaci-real, we concluded that the reset isn't mandatory. The certificates in the yubikey get overwritten either way. A pull request for removal will be made.

@meneerhenk what's your opinion on this?

@basvandriel basvandriel self-assigned this Dec 11, 2024
@basvandriel basvandriel linked a pull request Dec 11, 2024 that will close this issue
@basvandriel basvandriel linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant