YubiKey PIN input #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merging this, we should consider if we want to keep the resetting functionality. On the |
|
Yes that is needed to reset the YubiKey and for us to drop the old PIV keys and certificates. |
Do we need to reset everything? Can't we just reset the configuration and stored certificates? |
|
related to #49 |
|
Decided with the team to let this pull request stay in draft after we get more information about #50. |
|
Decided to not use this feature currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request lets the user provide a PIN code for the selected key and removes the need for providing it in the environment variables.