Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements #409: added strict monotonicity flag for hierarchical segmentation metrics #414

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tomxi
Copy link

@tomxi tomxi commented Feb 18, 2025

This PR implements issue #409.
It adds strict monotonicity flag for hierarchical segmentation metrics.
Also added new tests for coverage.

Soliciting feedback.

@tomxi
Copy link
Author

tomxi commented Feb 18, 2025

Besides the _meet function and l-measure mentioned in #409, this PR also gave t-measure and the _lca function the same treatment.

I also fixed up the doc string for _meet as it was copied over from _lca and needed a minor updates.

@tomxi
Copy link
Author

tomxi commented Feb 19, 2025

Hmm.. CI checks are failing after the unit tests, at the upload coverage to Codecov step...

Can I get some help/guidance on how to resolve this?

@bmcfee
Copy link
Collaborator

bmcfee commented Feb 19, 2025

Can I get some help/guidance on how to resolve this?

TLDR you can't. We went round on this with the codecov devs a couple weeks ago, and couldn't really resolve it but my suspicion is that something screwy happened with permissioning when we migrated to an organization repo. It works for PRs originating from the main repo, but not from forks.

We could make it so that failing coverage will not break the status, but that's not a great solution IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants