Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fixes #446

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Minor Fixes #446

merged 6 commits into from
Jul 12, 2024

Conversation

kavanase
Copy link
Contributor

This PR includes a few minor cosmetic updates:

  • Adds a CITATION.cff file to the NequIP repo (Misc project target for nequip-dev)
  • Updates the README and citation page on the docs (previously empty)
  • Some cleanup and fixes for the plot_dimers.py example script (had some accidental hard-set parameters etc)
  • Avoids accidental ""Do NOT manually set PYTORCH_JIT_USE_NNC_NOT_NVFUSER=0..." warning calls when PYTORCH_JIT_USE_NNC_NOT_NVFUSER in os.environ (but not set to 0)

@kavanase
Copy link
Contributor Author

Not sure if you also want to update this part of the readme @Linux-cpp-lisp to list active and previous developers?
image

@cw-tan
Copy link
Collaborator

cw-tan commented Jul 12, 2024

1509463 has already been addressed in the develop branch (see f937997)

@cw-tan cw-tan changed the base branch from main to develop July 12, 2024 19:51
Copy link
Collaborator

@Linux-cpp-lisp Linux-cpp-lisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Linux-cpp-lisp Linux-cpp-lisp merged commit ae635c2 into mir-group:develop Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants