-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line Editing for Irmin README #2325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I like it, I just had some minor suggestions for you to consider
Co-authored-by: art-w <[email protected]>
Co-authored-by: art-w <[email protected]>
Co-authored-by: art-w <[email protected]>
Co-authored-by: art-w <[email protected]>
Thanks so much! Committed all your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks :)
My pleasure! So happy to help! |
CHANGES: ### Added - **irmin-git** - Expose `Content_addressable` type (mirage/irmin#2329, @art-w) ### Changed - **irmin** - Rename `Node.S.effect` to `read_effect` for OCaml 5.3 compatibility (mirage/irmin#2347, @art-w) ### Fixed - **irmin-client** - Fix a fd leak when using `clone` (mirage/irmin#2322, @samoht) - **irmin-git** - Fix git sync example (mirage/irmin#2327, @art-w) - Fixed issue with two subsequent `Irmin-git` repos, where one repo would lose the ability to find its root path (mirage/irmin#2326, @zazedd) - **irmin** - Fix CI, update dependencies (mirage/irmin#2321, @smorimoto) - Update documentation (mirage/irmin#2323, mirage/irmin#2324, mirage/irmin#2325, @christinerose) - **irmin-cli** - Fix uncaught exception (mirage/irmin#2326, @art-w) ### Removed - **irmin** - Removed `?allow_duplicate` parameter from the `Conf.key` function (mirage/irmin#2326, @zazedd)
Please let me know if you need any changes.