Clean up the test and its use in CI #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pierre Alain <[email protected]>
The `example` and `test` directories are pretty-much duplicates, with only the configurability of the backend in the `test` as a notable difference, so merge them, keeping the configurability from `test` and the directory name from `example`, as it provides a good documentation for newcomers
Use dune's ability to interpolate strings with environment variables to eliminate intermediate files Use :standard link flags to simplify (and drop non-link) flags
CI time is spent almost entirely on building the compiler and packages so try out all the backends sequentially in a single job Normalise the step names on the way
The example should always return 0 with the fix of the missing return value
|
I like the changes, and when CI passes would be happy to merge them! Thanks a lot. |
dinosaure
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines a couple of small details that have been nagging me in the test and, partly as a consequence, also in CI.
The main changes are:
exampleandtestas they are really the same code (I kept the nameexampleto emphasize its use as documentation, but with the multiple backends of thetest, obviously),I hesitated to break it down into smaller PRs but those changes are fairly tightly coupled so the smaller PRs would have conflicted quite a bit. But that means I could easily drop some of changes this PR proposes.