Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native setters in documentation examples #1948

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

allthesignals
Copy link
Contributor

I think we should use native setter syntax in documentation examples. Is there a reason we should use .set? Backwards compatibility?

@Turbo87
Copy link
Collaborator

Turbo87 commented Apr 29, 2021

@allthesignals I don't think that this actually works properly. It works fine if you set these values before rendering a component, but setting it again afterwards won't invalidate the render, so AFAIK for now we still need the set() calls on the test context object.

@SergeAstapov SergeAstapov merged commit 16cdebd into miragejs:master Sep 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants