Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namespaced classes #130

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Use namespaced classes #130

merged 2 commits into from
Feb 14, 2025

Conversation

Universal-Omega
Copy link
Member

@Universal-Omega Universal-Omega commented Feb 14, 2025

Summary by CodeRabbit

  • Refactor
    • Updated import statements for various classes to use more specific namespaces, ensuring improved clarity and consistency. These updates do not affect the app’s behavior or visible functionality.

Copy link

coderabbitai bot commented Feb 14, 2025

Walkthrough

This pull request updates several import statements across multiple files to reference fully qualified namespaces. The changes replace generic or global class imports with more specific ones from the appropriate MediaWiki or Wikimedia namespaces. The functionality and logic of the files remain unchanged, with updates applied only to ensure clarity and precision in class resolution.

Changes

File(s) Change Summary
includes/ImportDumpOOUIForm.php Updated import: use Xml;use MediaWiki\Xml\Xml;
includes/ImportDumpRequestManager.php, includes/Jobs/ImportDumpNotifyJob.php, includes/Specials/SpecialRequestImport.php Updated ExtensionRegistry import to MediaWiki\Registration\ExtensionRegistry. In ImportDumpRequestManager.php, also updated FileBackend to Wikimedia\FileBackend\FileBackend; in SpecialRequestImport.php, updated MimeAnalyzer to Wikimedia\Mime\MimeAnalyzer.
includes/Jobs/ImportDumpJob.php Updated import: use FakeMaintenance;use MediaWiki\Maintenance\FakeMaintenance;

Possibly related PRs

Poem

Oh, hoppity-hop, I see fresh code,
Namespaces aligned on the same road.
Imports now clear like a bright moonbeam,
My rabbit eyes dance in the dream.
With every line, I skip and gleam! 🐇✨
CodeRabbit cheers for this clever scheme!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 95585f6 and a6e5abf.

📒 Files selected for processing (5)
  • includes/ImportDumpOOUIForm.php (1 hunks)
  • includes/ImportDumpRequestManager.php (2 hunks)
  • includes/Jobs/ImportDumpJob.php (1 hunks)
  • includes/Jobs/ImportDumpNotifyJob.php (1 hunks)
  • includes/Specials/SpecialRequestImport.php (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • includes/Jobs/ImportDumpJob.php
  • includes/ImportDumpOOUIForm.php
  • includes/Jobs/ImportDumpNotifyJob.php
  • includes/Specials/SpecialRequestImport.php
  • includes/ImportDumpRequestManager.php

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Check commit and GitHub actions for more details
@Universal-Omega Universal-Omega merged commit 12e65df into master Feb 14, 2025
1 check passed
@Universal-Omega Universal-Omega deleted the namespaced branch February 14, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant