Skip to content

Conversation

@miridius
Copy link
Owner

@miridius miridius commented Sep 12, 2021

TODO

  • Rework handler and VideoPost so that they pass every URL in each message to downloadVideo, and only send the video if it returns video data @miridius
  • Update downloadVideo to accept URLs, but return undefined for anything except v.redd.it links @miridius
  • Update downloadVideo (in src/io/download-video.js) to use youtube-dl instead of ffmpeg @zouden
    • Check in youtube-dl binary and license to the project like we did for ffmpeg. Probably easier to do Windows than Linux since the Linux version needs Python.
    • Probably need to add the FFmpeg path to PATH so that youtube-dl can find it
    • Try to download every URL, but check output for "ERROR: Unsupported URL: https://example.com" and in that case return nothing
    • Format opts (in config file?): -f 'bestvideo[ext=mp4][filesize<?45M]+bestaudio[ext=m4a][filesize<?5M]/best[ext=mp4][filesize<?50M]'
    • Note that for v.redd.it filesize is not known so we still need to check size of output
  • Update tests @miridius

@miridius
Copy link
Owner Author

@zouden actually I've been working on this myself as part of moving to AWS and it's nearly done, no need for you to work on it any more!

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 13, 2022

This pull request fixes 1 alert when merging d69de8c into ddbaf22 - view on LGTM.com

fixed alerts:

  • 1 for Shell command built from environment values

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 28, 2022

This pull request fixes 1 alert when merging d007db0 into ddbaf22 - view on LGTM.com

fixed alerts:

  • 1 for Shell command built from environment values

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 28, 2022

This pull request fixes 1 alert when merging aff0e6f into ddbaf22 - view on LGTM.com

fixed alerts:

  • 1 for Shell command built from environment values

Sending a video with a # in the filename causes the TG API call to hang

This then times out the AWS Lambda call causing an infinite retry loop
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 1, 2022

This pull request fixes 1 alert when merging 0838a63 into ddbaf22 - view on LGTM.com

fixed alerts:

  • 1 for Shell command built from environment values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants