-
Notifications
You must be signed in to change notification settings - Fork 1
WIP: Attempt to download all URLs found in messages using youtube-dl #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@zouden actually I've been working on this myself as part of moving to AWS and it's nearly done, no need for you to work on it any more! |
|
This pull request fixes 1 alert when merging d69de8c into ddbaf22 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging d007db0 into ddbaf22 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging aff0e6f into ddbaf22 - view on LGTM.com fixed alerts:
|
Sending a video with a # in the filename causes the TG API call to hang This then times out the AWS Lambda call causing an infinite retry loop
|
This pull request fixes 1 alert when merging 0838a63 into ddbaf22 - view on LGTM.com fixed alerts:
|
TODO
handlerandVideoPostso that they pass every URL in each message todownloadVideo, and only send the video if it returns video data @miridiusdownloadVideoto accept URLs, but return undefined for anything except v.redd.it links @miridiusdownloadVideo(insrc/io/download-video.js) to use youtube-dl instead of ffmpeg @zouden-f 'bestvideo[ext=mp4][filesize<?45M]+bestaudio[ext=m4a][filesize<?5M]/best[ext=mp4][filesize<?50M]'