Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPnP IGD: Improve wording and UI #452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Self-Hosting-Group
Copy link

@Self-Hosting-Group Self-Hosting-Group commented Dec 18, 2024

  • Remove Enabled table column as only enabled are shown and rearrange columns

Fixed in 8df0f4a eff5989 02eb8ff 3409e87

  • Remove Clear Port Forwards at Startup as it is always cleared

Fixed in 64d27e6 2d430f0

  • Left-align table headings to match the rest of the port forwarding tables and content, and describe it more clearly as Active Port Forwards rather than just Forwards
  • Use same wording (Port From/Port To) as in Port Forwarding
  • Use UPnP IGD to describe the protocol in more detail, as UPnP is also used for many services, e.g. media servers, and this newer/shorter wording is used in other router projects
  • Remove unused strings in lang_pack

dd-wrt
Screenshot 2024-10 beta release

The Port Control Protocol (PCP) is the successor to NAT-PMP, has similar protocol concepts and packet formats, but adds support for IPv6 port maps and options/extensions. For more information, see:
Port Mapping Protocols Overview and Comparison 2024: About UPnP IGD & PCP/NAT-PMP
https://github.com/Self-Hosting-Group/wiki/wiki/Port-Mapping-Protocols-Overview

Self-Hosting-Group added a commit to Self-Hosting-Group/dd-wrt that referenced this pull request Dec 18, 2024
@Self-Hosting-Group
Copy link
Author

This CSS would need to be inserted to align the table cells correctly:

#upnp_table tr td:not(:last-child) {
  padding-left: 0.543em;
}

Self-Hosting-Group added a commit to Self-Hosting-Group/dd-wrt that referenced this pull request Dec 30, 2024
Self-Hosting-Group added a commit to Self-Hosting-Group/dd-wrt that referenced this pull request Dec 31, 2024
Self-Hosting-Group added a commit to Self-Hosting-Group/dd-wrt that referenced this pull request Dec 31, 2024
@BrainSlayer
Copy link
Contributor

what do you mean with alignment. i made it different and have no alignment issues. i centered the table header names. but i see no issue and no reason for a css change in the gui. please explain

Self-Hosting-Group added a commit to Self-Hosting-Group/dd-wrt that referenced this pull request Dec 31, 2024
@Self-Hosting-Group
Copy link
Author

what do you mean with alignment. i made it different and have no alignment issues. i centered the table header names. but i see no issue and no reason for a css change in the gui. please explain

Currently:
cellpadding
Compare this to the screenshot above, in my eyes the cells need the padding to look good.

@BrainSlayer
Copy link
Contributor

what do you mean with alignment. i made it different and have no alignment issues. i centered the table header names. but i see no issue and no reason for a css change in the gui. please explain

Currently: cellpadding Compare this to the screenshot above, in my eyes the cells need the padding to look good.

that would only make sense if you change all tables in dd-wrt, just upnp makes no sense of port forwarding etc. are still using the old padding.

Self-Hosting-Group added a commit to Self-Hosting-Group/dd-wrt that referenced this pull request Dec 31, 2024
Self-Hosting-Group added a commit to Self-Hosting-Group/dd-wrt that referenced this pull request Dec 31, 2024
Self-Hosting-Group added a commit to Self-Hosting-Group/dd-wrt that referenced this pull request Jan 2, 2025
Self-Hosting-Group added a commit to Self-Hosting-Group/dd-wrt that referenced this pull request Jan 2, 2025
@Self-Hosting-Group Self-Hosting-Group force-pushed the improve-wording branch 2 times, most recently from 0b21dc0 to a2f3b21 Compare January 2, 2025 06:26
@BrainSlayer
Copy link
Contributor

i will not put IGD behind all upnp words. its waste of space, uncommon and not neccessary. check all other router ui's of all vendors you will nowhere find this.

@BrainSlayer
Copy link
Contributor

and yes i checked it. nobody uses it

@Self-Hosting-Group
Copy link
Author

and yes i checked it. nobody uses it

Some router UI screenshots that use UPnP IGD:

i will not put IGD behind all upnp words. its waste of space, uncommon and not neccessary.

What solid arguments, even if you consider that the title (H2) is massively shortened.

@BrainSlayer
Copy link
Contributor

BrainSlayer commented Jan 9, 2025

the argument is common use.

i checked current asus firmware source. upnp igd is nowhere mentioned. i also checked dlink and tp link firmwares.
but please do not present me screenshots you fucked up by yourself. i checked the merlin-ng sourcecode. you have done this modification. dont fool me. if i check the other projects i'm sure i will find out the same. very bad proof. try better

@BrainSlayer
Copy link
Contributor

BrainSlayer commented Jan 9, 2025

you should reflect your actions. your screenshot posts are simply not valid as any argument since you made them up by modifying the projects you presented. i said nobody is using the term you wanted in the ui but you instead try to fool me with screeshots you made up by injecting your own modifications into these projects. but these modifications are far from common use or wording. it reflects just your own oppinion and no standard or valid argument. this is no honest handling or discussion if you go that way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants