Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: DROP 3.8, leverage hatch to run tests and static analisys #1221

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

pkucmus
Copy link
Contributor

@pkucmus pkucmus commented Jan 30, 2025

  • provide explicit configs for mypy, ruff, coverage
  • Python 3.8 support is dropped
  • Python 3.13 support introduced

Related to #1220

What needs to be done:

  • make a commit that will fix style issues (summary bellow)
  • ignore the style commit in .git-blame-ignore-revs
  • fix mypy errors (summary bellow)
  • update GitHub actions
  • update CONTRIBUTING.md

Ruff error summary:

> ruff check --statistics
175	UP006	[*] non-pep585-annotation
 65	UP035	[ ] deprecated-import
 59	E501 	[ ] line-too-long
 38	I001 	[*] unsorted-imports
 27	UP031	[ ] printf-string-formatting
 17	C901 	[ ] complex-structure
  8	UP032	[*] f-string
  6	F841 	[*] unused-variable
  5	UP015	[*] redundant-open-modes
  4	N806 	[ ] non-lowercase-variable-in-function
  4	UP012	[*] unnecessary-encode-utf8
  3	T201 	[*] print
  3	F401 	[ ] unused-import
  2	N803 	[ ] invalid-argument-name
  2	N815 	[ ] mixed-case-variable-in-class-scope
  2	UP037	[*] quoted-annotation
  1	N802 	[ ] invalid-function-name
  1	E713 	[*] not-in-test
  1	F811 	[ ] redefined-while-unused
  1	F821 	[ ] undefined-name
[*] fixable with `ruff check --fix`

Mypy error list:

> hatch run types:check
ariadne/asgi/handlers/graphql_transport_ws.py:14: error: Module "ariadne.types" does not explicitly export attribute "ExecutionResult"  [attr-defined]
ariadne/__init__.py:17: error: Module "ariadne.interfaces" does not explicitly export attribute "type_implements_interface"  [attr-defined]
ariadne/contrib/sse.py:38: error: Module "ariadne.graphql" does not explicitly export attribute "ExecutionResult"  [attr-defined]
ariadne/contrib/sse.py:38: error: Module "ariadne.graphql" does not explicitly export attribute "GraphQLError"  [attr-defined]
Found 4 errors in 3 files (checked 58 source files)

@pkucmus
Copy link
Contributor Author

pkucmus commented Jan 30, 2025

@rafalp do you care about such stuff at all?

@rafalp
Copy link
Collaborator

rafalp commented Jan 30, 2025

I am not sure what you are asking?

@pkucmus
Copy link
Contributor Author

pkucmus commented Jan 30, 2025

If you have an opinion on the matter, do you want to have an opinion on this?

@rafalp
Copy link
Collaborator

rafalp commented Jan 30, 2025

Oh, I don't. You should do what works for you as new maintainer. Unifying setup with other projects you are responsible for is good reason for doing this. Also good on updating Python versions matrix.

@KarolJagodzinski KarolJagodzinski force-pushed the feature/tooling branch 2 times, most recently from a514e4e to d37946e Compare February 17, 2025 18:59
@pkucmus
Copy link
Contributor Author

pkucmus commented Feb 18, 2025

Nice, good job Karol!

@pkucmus pkucmus added this to the 0.26.0 milestone Feb 18, 2025
@KarolJagodzinski KarolJagodzinski merged commit d315778 into main Feb 18, 2025
20 checks passed
@KarolJagodzinski KarolJagodzinski deleted the feature/tooling branch February 18, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants