-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bootstrap_4(_horizontal)_layout.html.twig #181
base: master
Are you sure you want to change the base?
Add support for bootstrap_4(_horizontal)_layout.html.twig #181
Conversation
Just looking very briefly I’m not sure what this code is originally for - did you work it out? |
Symfony has built in form themes for Bootstrap 3 and newly added Bootstrap 4: The phone number bundle worked when Bootstrap 3 form theme was activated but does not work with Bootstrap 4. This pull request fixes this issue. |
Also see #179 |
+1, need this fix |
+1 |
Until this is fixed you can use my fork: @rh389 What about my pull request, is something not ok? Maybe you should disable tests on hhvm in Travis CI, seems there is no code coverage driver configured |
any update about this PR? |
Can we expect a solution for bootstrap 4 forms ? Is is still not working... |
Hi, why about one year later this pull request is still not accepted ? |
@rh389 Hi, can you accept up this PR please ? |
If you want, you can redirect your PR to this repo : https://github.com/odolbeau/phone-number-bundle |
No description provided.