Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bootstrap_4(_horizontal)_layout.html.twig #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mathiasstocker
Copy link

No description provided.

@robhogan
Copy link
Member

Just looking very briefly I’m not sure what this code is originally for - did you work it out?

@mathiasstocker
Copy link
Author

Symfony has built in form themes for Bootstrap 3 and newly added Bootstrap 4:
https://symfony.com/doc/current/form/form_customization.html#what-are-form-themes

The phone number bundle worked when Bootstrap 3 form theme was activated but does not work with Bootstrap 4.

This pull request fixes this issue.

@mathiasstocker
Copy link
Author

Also see #179

@claire1604
Copy link

+1, need this fix

@ruscon
Copy link

ruscon commented Aug 25, 2018

+1

@mathiasstocker
Copy link
Author

Until this is fixed you can use my fork:
https://github.com/mathiasstocker/phone-number-bundle

@rh389 What about my pull request, is something not ok? Maybe you should disable tests on hhvm in Travis CI, seems there is no code coverage driver configured

@kariae
Copy link

kariae commented Nov 4, 2018

any update about this PR?

@effetb
Copy link

effetb commented Jan 11, 2019

Can we expect a solution for bootstrap 4 forms ? Is is still not working...

@effetb
Copy link

effetb commented Apr 10, 2019

Hi, why about one year later this pull request is still not accepted ?

@florianlemenach
Copy link

@rh389 Hi, can you accept up this PR please ?

@maxhelias
Copy link

If you want, you can redirect your PR to this repo : https://github.com/odolbeau/phone-number-bundle
We would be happy to merge this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants