Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing tss-react dependency #3

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Removing tss-react dependency #3

merged 1 commit into from
Aug 22, 2024

Conversation

garronej
Copy link
Contributor

Hello,

I was reviewing your setup, good job!

Since you've opted for using @emotion as your styling solution I figured that it dosen't make much sens to have tss-react as well.

I also removed @emotion/server since it isn't nessesary in Next App Router setups.

One more thing I noted is that you're hardcoding the dsfr color values and that you're using colors options instead of the colors decision.
Are you aware of this tool?

https://components.react-dsfr.codegouv.studio/?path=/docs/%F0%9F%8E%A8-color-helper--page

You can replace:

<Typography
  variant="h5"
  style={{ 
    color: "var(--blue-france-sun-113-625)", 
    marginBottom: fr.spacing("3v") 
  }}
>

</Typography>

by:

<Typography
  variant="h5"
  style={{ 
    color: fr.colors.decisions.background.flat.blueFrance.default, 
    marginBottom: fr.spacing("3v") 
  }}
>

</Typography>

This way you're getting type safety.

@K4ST0R
Copy link
Collaborator

K4ST0R commented Aug 22, 2024

Hello,

Thank you for your review and your modifications!

I was not aware of this tool, I will use colors decision now! :)

@K4ST0R K4ST0R merged commit 0f59caa into mission-apprentissage:main Aug 22, 2024
2 checks passed
@antoinebigard
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants