Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was reviewing your setup, good job!
Since you've opted for using
@emotion
as your styling solution I figured that it dosen't make much sens to havetss-react
as well.I also removed
@emotion/server
since it isn't nessesary in Next App Router setups.One more thing I noted is that you're hardcoding the dsfr color values and that you're using colors options instead of the colors decision.
Are you aware of this tool?
https://components.react-dsfr.codegouv.studio/?path=/docs/%F0%9F%8E%A8-color-helper--page
You can replace:
by:
This way you're getting type safety.