feat: LBAC-1658 revue/sécu routes (#771)

* feat: cleaning comment * feat: conversion commentaires en tickets * feat: converti en ticket * feat: cleaning. scheme déjà fait * feat: scheme déjà fait
mission-apprentissage · Nov 7, 2023 · 545dd46 · 545dd46
1 parent 799788f
commit 545dd46
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 9 deletions.
diff --git a/shared/routes/application.routes.ts b/shared/routes/application.routes.ts
@@ -56,12 +56,11 @@ export const zApplicationRoutes = {
       securityScheme: null,
     },
     "/application/intentionComment": {
-      // TODO_SECURITY_FIX
       path: "/application/intentionComment",
       method: "post",
       body: z
         .object({
-          id: z.string(), // inutile de chiffrer l'id, rajouter un champ token qui contiendra l'id
+          id: z.string(),
           iv: z.string(),
           comment: z.string(),
           intention: z.string(),

diff --git a/shared/routes/rome.routes.ts b/shared/routes/rome.routes.ts
@@ -24,7 +24,6 @@ export const zRomeRoutes = {
     "/rome/detail/:rome": {
       method: "get",
       path: "/rome/detail/:rome",
-      // TODO filtrer la payload
       params: z
         .object({
           rome: z.string(),

diff --git a/shared/routes/unsubscribe.routes.ts b/shared/routes/unsubscribe.routes.ts
@@ -5,7 +5,6 @@ import { IRoutesDef } from "./common.routes"
 
 export const zUnsubscribeRoute = {
   post: {
-    // TODO_SECURITY AB Vs. Marion + Abdellah + Léo !! fight !!
     "/unsubscribe": {
       method: "post",
       path: "/unsubscribe",

diff --git a/shared/routes/updateLbaCompany.routes.ts b/shared/routes/updateLbaCompany.routes.ts
@@ -6,7 +6,6 @@ import { IRoutesDef } from "./common.routes"
 
 export const zUpdateLbaCompanyRoutes = {
   get: {
-    // TODO_SECURITY passer en session role is-admin et faire un formulaire (migrer en POST)
     "/updateLBB/updateContactInfo": {
       method: "get",
       path: "/updateLBB/updateContactInfo",

diff --git a/shared/routes/v1Jobs.routes.ts b/shared/routes/v1Jobs.routes.ts
@@ -456,7 +456,6 @@ export const zV1JobsRoutes = {
     "/v1/jobs/provided/:jobId": {
       method: "post",
       path: "/v1/jobs/provided/:jobId",
-      // TODO_SECURITY_FIX vérifier le scope au moment de l'update du statut de l'offre
       params: z
         .object({
           jobId: zObjectId,
@@ -481,7 +480,6 @@ export const zV1JobsRoutes = {
     "/v1/jobs/canceled/:jobId": {
       method: "post",
       path: "/v1/jobs/canceled/:jobId",
-      // TODO_SECURITY_FIX vérifier le scope au moment de l'update du statut de l'offre
       params: z
         .object({
           jobId: zObjectId,
@@ -506,7 +504,6 @@ export const zV1JobsRoutes = {
     "/v1/jobs/extend/:jobId": {
       method: "post",
       path: "/v1/jobs/extend/:jobId",
-      // TODO_SECURITY_FIX vérifier le scope au moment de l'update du statut de l'offre
       params: z
         .object({
           jobId: zObjectId,
@@ -551,7 +548,6 @@ export const zV1JobsRoutes = {
     "/v1/jobs/:jobId": {
       method: "patch",
       path: "/v1/jobs/:jobId",
-      // TODO_SECURITY_FIX vérifier le scope au moment de l'update du statut de l'offre
       params: z
         .object({
           jobId: zObjectId,