fix(lbac-2305): remove pending state (#1700)

* fix: remove pending state * fix: snapshot * fix: keep status transformation for get single job
mission-apprentissage · Dec 11, 2024 · 84f49e7 · 84f49e7
1 parent 831c520
commit 84f49e7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/server/src/services/jobs/jobOpportunity/jobOpportunity.service.ts b/server/src/services/jobs/jobOpportunity/jobOpportunity.service.ts
@@ -375,7 +375,7 @@ export const convertLbaRecruiterToJobOfferApi = (offresEmploiLba: IJobResult[]):
               expiration: job.job_expiration_date ?? null,
             },
             opening_count: job.job_count ?? 1,
-            status: translateJobStatus(job.job_status),
+            status: translateJobStatus(job.job_status)!,
           },
 
           workplace: {

diff --git a/shared/helpers/openapi/__snapshots__/generateOpenapi.test.ts.snap b/shared/helpers/openapi/__snapshots__/generateOpenapi.test.ts.snap
@@ -9847,7 +9847,6 @@ Limite : 20 appel(s) / 1 seconde(s)
                           "Active",
                           "Filled",
                           "Cancelled",
-                          "Pending",
                         ],
                         "type": "string",
                       },
@@ -10249,7 +10248,6 @@ Limite : 20 appel(s) / 1 seconde(s)
                                   "Active",
                                   "Filled",
                                   "Cancelled",
-                                  "Pending",
                                 ],
                                 "type": "string",
                               },
@@ -10942,7 +10940,6 @@ Limite : 20 appel(s) / 1 seconde(s)
                           "Active",
                           "Filled",
                           "Cancelled",
-                          "Pending",
                         ],
                         "type": "string",
                       },

diff --git a/shared/models/job.model.ts b/shared/models/job.model.ts
@@ -19,10 +19,9 @@ export enum JOB_STATUS_ENGLISH {
   ACTIVE = "Active",
   POURVUE = "Filled",
   ANNULEE = "Cancelled",
-  EN_ATTENTE = "Pending",
 }
 
-export function translateJobStatus(status: JOB_STATUS): JOB_STATUS_ENGLISH {
+export function translateJobStatus(status: JOB_STATUS): JOB_STATUS_ENGLISH | undefined {
   switch (status) {
     case JOB_STATUS.ACTIVE:
       return JOB_STATUS_ENGLISH.ACTIVE
@@ -31,7 +30,7 @@ export function translateJobStatus(status: JOB_STATUS): JOB_STATUS_ENGLISH {
     case JOB_STATUS.ANNULEE:
       return JOB_STATUS_ENGLISH.ANNULEE
     case JOB_STATUS.EN_ATTENTE:
-      return JOB_STATUS_ENGLISH.EN_ATTENTE
+      return undefined
     default:
       assertUnreachable(status)
   }