Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lbac-2266): new applicant collection #1723

Merged
merged 18 commits into from
Dec 26, 2024
Merged

feat(lbac-2266): new applicant collection #1723

merged 18 commits into from
Dec 26, 2024

Conversation

kevbarns
Copy link
Collaborator

@kevbarns kevbarns commented Dec 18, 2024 •
edited
Loading

Détails :

  • Fichier de migration pour alimenter la collection applicants : le job prend environ 13 minutes après test avec les données de production
  • les champs du candidat ne sont pas supprimé, ils le seront dans un second temps, le temps de valider ce changement. Cependant, tous les services s'appuie maintenant sur la collection applicants pour récupérer les données du candidat.
  • Ajout d'un statut ERROR_APPLICANT_NOT_FOUND lors de l'envoie des candidatures en failsafe.
  • Simplification de la fonction de validation du numéro de téléphone: la méthode isValid() retourne trop souvent de faux-negatif

@kevbarns kevbarns self-assigned this Dec 18, 2024
@github-actions GitHub Actions
Copy link

To deploy this PR just add a comment with a simple 🚀

@kevbarns kevbarns changed the title feat(lbac 2266): new applicant collection feat(lbac-2266): new applicant collection Dec 18, 2024
@kevbarns kevbarns marked this pull request as ready for review December 19, 2024 15:35
@kevbarns kevbarns requested a review from a team as a code owner December 19, 2024 15:35
alanlr
alanlr requested changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@alanlr alanlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai l'impression qu'il manque un toLowerCase sur l'adresse email de l'applicant à caser quelque part au niveau des contrôleurs ou des transformations zod

shared/models/applicant.model.ts Outdated Show resolved Hide resolved
server/src/services/applicant.service.ts Outdated Show resolved Hide resolved
server/src/migrations/20241217092523-migration-applications-to-applicants.ts Show resolved Hide resolved
server/src/migrations/20241217092523-migration-applications-to-applicants.ts Show resolved Hide resolved
@kevbarns kevbarns mentioned this pull request Dec 23, 2024
Merged
@kevbarns kevbarns merged commit 0e9ab12 into main Dec 26, 2024
6 checks passed
@kevbarns kevbarns deleted the feat(lbac-2266)-new-applicant-collection branch December 26, 2024 11:13
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.509.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanlr alanlr alanlr requested changes

Assignees

@kevbarns kevbarns

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevbarns @alanlr