Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: view transition #15642

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

wip: view transition #15642

wants to merge 3 commits into from

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Mar 10, 2025

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 10, 2025
@syuilo
Copy link
Member Author

syuilo commented Mar 10, 2025

Chromeで試してるけど、画面全体のクロスフェードは行われるけど要素間の遷移が行われない(view-transition-nameは適切に設定されている)

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 15.39%. Comparing base (9dce512) to head (be16622).

Files with missing lines Patch % Lines
packages/frontend/src/pages/notifications.vue 0.00% 2 Missing ⚠️
packages/frontend/src/pages/timeline.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15642       +/-   ##
============================================
- Coverage    41.92%   15.39%   -26.54%     
============================================
  Files         1624      786      -838     
  Lines       165871    72196    -93675     
  Branches      4106     1278     -2828     
============================================
- Hits         69540    11113    -58427     
+ Misses       95854    60659    -35195     
+ Partials       477      424       -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@syuilo
Copy link
Member Author

syuilo commented Mar 10, 2025

9dce512
こういうページ間ではなくコンポーネントの状態が変わるだけのシンプルなトランジションなら動いた
a

@syuilo
Copy link
Member Author

syuilo commented Mar 10, 2025

universal.vue で RouterView を MkStickyContainer で包むのをやめたら動作した

@syuilo
Copy link
Member Author

syuilo commented Mar 10, 2025

MkStickyContainer のままでも、それにあたってるスタイル(つまり以下)を消したら動作した

style="container-type: inline-size;"

.contents {
	flex: 1;
	height: 100%;
	min-width: 0;
	overflow: auto;
	overflow-y: scroll;
	overscroll-behavior: contain;
	background: var(--MI_THEME-bg);
	scroll-padding-top: 60px; // TODO: ちゃんと計算する
	scroll-padding-bottom: 60px; // TODO: ちゃんと計算する
}

@tai-cha
Copy link
Contributor

tai-cha commented Mar 10, 2025

ミニマムでcontainer-type: inline-size;flex: 1;が消えたら動作してそう

@syuilo
Copy link
Member Author

syuilo commented Mar 10, 2025

@syuilo
Copy link
Member Author

syuilo commented Mar 10, 2025

Blinkのバグかしら

@tai-cha
Copy link
Contributor

tai-cha commented Mar 10, 2025

overflow-yを消した場合にもtransitionしていそう
動きの制限があるとき正常に動作しない可能性

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants