correction to use with sails 1.0

[dcunited001]

Can this be safely merged in? (again, I'm a sails noob, but I'd like to use a consistent remote/head for the project.)

[ndarilek]

Would love to see this merged if it can happen as well. Also new to Sails but need this for a legacy project. Anyone more knowledgable than me care to comment?

Thanks!

[ndarilek]

I just merged #6 and #5 here. We need this for a project, so if anyone could test and make sure it works, that'd be great. I'd rather not have to maintain this as I don't know what's involved, but at least now there's a place to get code that might work on Sails >1.

[misterGF]

I believe this would break backwards compatibility. Haven't had the time yet to look into it.

Can you resubmit this PR to the v1 branch? We can use that for V1 users and keep master for the 0.x users (for now).

[ndarilek]

This isn't my PR, but I don't see a v1 branch. Is it called something else?

In any case, I'm having some issues getting this to work. The stacktrace I'm currently getting isn't valid for any committed code since I'm inserting logging and my line numbers are off, but basically it's:

TypeError: Cannot read property 'definition' of undefined
    at Object.getPrimaryKey (/host/node_modules/sails-mssqlserver/lib/adapter.js:545:57)

I think that's the right line number, I'm adjusting it for the logging I've added. In my code it reads:

        connections[connection].collections[collection].definition

Anyhow, I'm about to wrap up for the week here, but will continue looking into this next week. Hopefully it's just a quick fix. Just thought I'd put it out there in case anyone had any thoughts.

[ndarilek]

FWIW, the fix isn't a quick one. Various functions, parameter names, shapes, etc. have changed post Sails 1.0.

I'm very slowly working on bringing this up to spec at https://github.com/ndarilek/sails-mssqlserver/tree/v1/. I don't really know mssql, am using it in anger, and just want to get this working. As such, some of my code is a bit ugly. Help very much appreciated, especially as Sails doesn't really document their adapter spec.

Thanks.

[HeywoodKing]

hello,I'm a sails noob, I want to connect the sqlserver database in a sail 1.0,For help

[ndarilek]

I just gave up. We'd eventually like to migrate to something like Postgres anyway. For the moment I'm using the mssql NPM package directly and just ignoring models. Sails' connector spec is, AFAICT, just a bullet-pointed list of method names (no implementation details beyond that) and it was just too much to port this. Sorry.