Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configure step to manual parsec seup instructions #242

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

anders94
Copy link
Collaborator

@anders94 anders94 commented Jan 3, 2024

Add ./scripts/configure.sh to docs/parsec_user_guide.md

Copy link
Collaborator

@maurermi maurermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept-ACK, left a comment that I think is worth considering but I have no real issue with this proposed change

docs/parsec_user_guide.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@HalosGhost HalosGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple doc improvement to clarify the need to ./configure. Looks good to me.

@HalosGhost
Copy link
Collaborator

@anders94 if you're good to squash, I can merge right away.

…tions

Signed-off-by: Anders Brownworth <[email protected]>

Address Michael's suggestion adding a note about only necessary once

Signed-off-by: Anders Brownworth <[email protected]>
@HalosGhost
Copy link
Collaborator

looks like one of the parsec tests had a flakey moment and failed (couldn't be related to the single doc-change). Merging.

@HalosGhost HalosGhost merged commit c156258 into mit-dci:trunk Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants