Skip to content

Commit

Permalink
Use a simpler version of skipping the asm builds
Browse files Browse the repository at this point in the history
  • Loading branch information
JasonGross committed Oct 23, 2023
1 parent 3378f57 commit df5c158
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 120 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/c.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ jobs:
- name: make only-test-bedrock2-files CC=gcc
run: make only-test-bedrock2-files CC=gcc EXTERNAL_DEPENDENCIES=1
- name: BoringSSL C test
run: EXTRA_CFLAGS="" PATCH_FOLDER="etc/ci/boringssl-patches/" etc/ci/test-fiat-c-boringssl.sh fiat-c/src
run: EXTRA_CFLAGS="" etc/ci/test-fiat-c-boringssl.sh fiat-c/src
- name: BoringSSL bedrock2 test
run: EXTRA_CFLAGS="$(make bedrock2-extra-cflags SKIP_INCLUDE=1 2>/dev/null)" PATCH_FOLDER="etc/ci/boringssl-bedrock2-patches/" etc/ci/test-fiat-c-boringssl.sh fiat-bedrock2/src
run: EXTRA_CFLAGS="$(make bedrock2-extra-cflags SKIP_INCLUDE=1 2>/dev/null)" etc/ci/test-fiat-c-boringssl.sh fiat-bedrock2/src
42 changes: 0 additions & 42 deletions etc/ci/boringssl-bedrock2-patches/2023-10-05-p256-adx.patch

This file was deleted.

62 changes: 0 additions & 62 deletions etc/ci/boringssl-patches/2023-10-05-p256-adx.patch

This file was deleted.

15 changes: 1 addition & 14 deletions etc/ci/test-fiat-c-boringssl.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
#!/usr/bin/env bash
# USAGE: $0 SUBCOMPONENT (e.g., fiat-c/src)

DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

################################################################################
# Tests for BoringSSL
################################################################################
Expand All @@ -24,10 +22,6 @@ if [ -z "$SUBCOMPONENT" ]; then
fi
SUBCOMPONENT_PATH="$(cd "$SUBCOMPONENT" && pwd)"

if [ ! -z "${PATCH_FOLDER}" ]; then
PATCH_FOLDER="$(realpath "${PATCH_FOLDER}")"
fi

pushd boringssl >/dev/null

echo "::group::Patching BoringSSL"
Expand All @@ -38,13 +32,6 @@ echo "::group::Patching BoringSSL"
cp "${SUBCOMPONENT_PATH}/${i/.h/.c}" "$i" || exit $?
done ) || exit $?
( cd third_party/fiat && git --no-pager diff )
if [ ! -z "${PATCH_FOLDER}" ]; then
( cd third_party/fiat &&
for i in "${PATCH_FOLDER}"/*.patch; do
git apply "$i"
done ) || exit $?
fi
( cd third_party/fiat && git --no-pager diff )
}) || exit $?
echo "::endgroup::"

Expand All @@ -53,7 +40,7 @@ echo "::group::Building BoringSSL"
set -ex
mkdir build
cd build
cmake -GNinja .. -DCMAKE_CXX_FLAGS="-Wno-error=unused-function ${EXTRA_CFLAGS}" -DCMAKE_C_FLAGS="-Wno-error=unused-function ${EXTRA_CFLAGS}" || exit $?
cmake -GNinja .. -DOPENSSL_NO_ASM=1 -DCMAKE_CXX_FLAGS="-Wno-error=unused-function ${EXTRA_CFLAGS}" -DCMAKE_C_FLAGS="-Wno-error=unused-function ${EXTRA_CFLAGS}" || exit $?
ninja || exit $?
}) || exit $?
echo "::endgroup::"
Expand Down

0 comments on commit df5c158

Please sign in to comment.