Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch BoringSSL files for C tests #1692

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Patch BoringSSL files for C tests #1692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3378f57
Patch BoringSSL files for C tests
JasonGross Oct 22, 2023
df5c158
Use a simpler version of skipping the asm builds
JasonGross Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etc/ci/test-fiat-c-boringssl.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ echo "::group::Building BoringSSL"
set -ex
mkdir build
cd build
cmake -GNinja .. -DCMAKE_CXX_FLAGS="-Wno-error=unused-function ${EXTRA_CFLAGS}" -DCMAKE_C_FLAGS="-Wno-error=unused-function ${EXTRA_CFLAGS}" || exit $?
cmake -GNinja .. -DOPENSSL_NO_ASM=1 -DCMAKE_CXX_FLAGS="-Wno-error=unused-function ${EXTRA_CFLAGS}" -DCMAKE_C_FLAGS="-Wno-error=unused-function ${EXTRA_CFLAGS}" || exit $?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andres-erbsen you suggested

env CC=clang CXX=clang++ cmake -GNinja -B build-noasm -DOPENSSL_NO_ASM=1 -DCMAKE_BUILD_TYPE=Release seems to work for me

What's the relationship between .. and -B build-noasm (if any)? What's the importance of -B build-noasm?

And what are your thoughts on -DCMAKE_BUILD_TYPE=Release vs -DCMAKE_CXX_FLAGS="-Wno-error=unused-function ${EXTRA_CFLAGS}" -DCMAKE_C_FLAGS="-Wno-error=unused-function ${EXTRA_CFLAGS}"? (EXTRA_CFLAGS gets set to -Wno-error=unused-but-set-variable by CI)

ninja || exit $?
}) || exit $?
echo "::endgroup::"
Expand Down