Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ocaml/setup-ocaml from 2 to 3 #1939

Merged
merged 8 commits into from
Sep 20, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 31, 2024

Bumps ocaml/setup-ocaml from 2 to 3.

Release notes

Sourced from ocaml/setup-ocaml's releases.

v3.0.0

  • This was a version bump only, there were no code changes.

v3.0.0-beta1

Fixed

  • Fix asset selector to select the correct opam release asset.

v3.0.0-beta

Changed

  • Always set-up Cygwin whether or not the cache is hit.

v3.0.0-alpha

Added

  • Add initial support for opam 2.2 on Windows.

v2.2.10

Changed

  • Update runtime dependencies.

v2.2.9

Changed

  • Do not explicitly call the depext subcommand unless required.
  • Do not set HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK to 1 while installing OCaml.
  • Update runtime dependencies.

v2.2.8

Changed

  • Update runtime dependencies.

v2.2.7

Changed

  • Update runtime dependencies.

v2.2.6

Changed

  • Update runtime dependencies.

v2.2.5

Changed

  • Update runtime dependencies.

... (truncated)

Changelog

Sourced from ocaml/setup-ocaml's changelog.

[2.0.13]

Fixed

  • Ensure cache key creation works with local opam repositories.

[2.0.12]

Changed

  • Use ocaml-opam/opam-repository-mingw instead of fdopen/opam-repository-mingw.

Fixed

  • Fix in 2.0.11 for hashing caused an invalid git configuration to be written.

[2.0.11]

Changed

  • Don't install Cygwin's git or mercurial packages (reduces cache by ~90MB).

Fixed

  • Ensure ocaml/opam-repository can be added without getting hash errors.

[2.0.10]

Fixed

  • Speed up caching and get rid of bugs and hacks on Windows.

[2.0.9]

Fixed

  • Take the sandbox option value into account when computing the cache key.

[2.0.8]

Changed

  • Make the retry handling around unix package installation simple back.

Fixed

  • Make the retry handling around depext package installation more robust.

[2.0.7]

... (truncated)

Commits
  • aab8e20 Prepare 3.0.0
  • bbdb0fb Prepare 3.0.0-beta1
  • 0a1157c Merge pull request #820 from ocaml/fix-opam-selector
  • 672583e Fix asset selector to select the correct opam release asset
  • 15003b1 Update .github/workflows/workflow.yml
  • a75f4ba Update typescript to 5.5.3
  • 076fb65 Update npm deps
  • 513ca4e Merge pull request #819 from ocaml/dependabot/github_actions/github/codeql-ac...
  • d87de45 Bump github/codeql-action from 3.25.10 to 3.25.11
  • 92dde8c Prepare 3.0.0-beta
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@github-actions github-actions bot enabled auto-merge (squash) July 31, 2024 04:36
@JasonGross
Copy link
Collaborator

#1925 (comment)

@JasonGross JasonGross force-pushed the dependabot/github_actions/ocaml/setup-ocaml-3 branch from e958063 to fe290f7 Compare August 5, 2024 23:46
@JasonGross
Copy link
Collaborator

@hhugo what about this error?


# make[1]: Entering directory '/cygdrive/d/a/fiat-crypto/fiat-crypto/_opam/.opam-switch/build/ocamlfind.1.9.6.git'
# USE_CYGPATH="1"; \
# export USE_CYGPATH; \
# cat findlib.conf.in | \
#      tools/patch '@SITELIB@' 'D:\a\fiat-crypto\fiat-crypto\_opam\lib' | \
# 		 tools/patch '@FINDLIB_PATH@' 'D:\a\fiat-crypto\fiat-crypto\_opam\lib' -p >findlib.conf
# sed: -e expression #1, char 20: unknown option to `s

@hhugo
Copy link

hhugo commented Sep 3, 2024

@hhugo what about this error?


# make[1]: Entering directory '/cygdrive/d/a/fiat-crypto/fiat-crypto/_opam/.opam-switch/build/ocamlfind.1.9.6.git'
# USE_CYGPATH="1"; \
# export USE_CYGPATH; \
# cat findlib.conf.in | \
#      tools/patch '@SITELIB@' 'D:\a\fiat-crypto\fiat-crypto\_opam\lib' | \
# 		 tools/patch '@FINDLIB_PATH@' 'D:\a\fiat-crypto\fiat-crypto\_opam\lib' -p >findlib.conf
# sed: -e expression #1, char 20: unknown option to `s

Looks like ocaml/ocamlfind#63

@JasonGross JasonGross force-pushed the dependabot/github_actions/ocaml/setup-ocaml-3 branch from fe290f7 to ac35595 Compare September 6, 2024 01:26
@hhugo
Copy link

hhugo commented Sep 9, 2024

The 2 ocamlfind fixes have been merged upstream, you should be able to pin ocamlfind against the upstream master

@JasonGross JasonGross force-pushed the dependabot/github_actions/ocaml/setup-ocaml-3 branch 2 times, most recently from 14bf037 to 26e8516 Compare September 19, 2024 23:49
@JasonGross JasonGross force-pushed the dependabot/github_actions/ocaml/setup-ocaml-3 branch from 26e8516 to d2e3c2e Compare September 20, 2024 00:28
@JasonGross JasonGross disabled auto-merge September 20, 2024 00:28
@JasonGross JasonGross merged commit 15f63d0 into master Sep 20, 2024
19 of 20 checks passed
@JasonGross JasonGross deleted the dependabot/github_actions/ocaml/setup-ocaml-3 branch September 20, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants