Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to https://github.com/coq/coq/pull/19530 #1992

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Adapt to https://github.com/coq/coq/pull/19530 #1992

merged 1 commit into from
Dec 5, 2024

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Dec 5, 2024

Can be merged at any time

@proux01 proux01 mentioned this pull request Dec 5, 2024
Merged
43 tasks
@JasonGross
Copy link
Collaborator

@proux01 can you explain what coq/coq#19530 changes that makes this required?

@proux01
Copy link
Contributor Author

proux01 commented Dec 5, 2024

It's about the selective Import byte(..). Since we now have a wrapper in Stdlib, we need the Require to use the compatibility code of Coq. Without the selective import, no changes would be needed.

@JasonGross JasonGross enabled auto-merge (squash) December 5, 2024 08:19
@JasonGross JasonGross merged commit 8eccaf2 into mit-plv:master Dec 5, 2024
52 checks passed
@proux01
Copy link
Contributor Author

proux01 commented Dec 5, 2024

Thanks

@proux01 proux01 deleted the stdlib_repo branch December 5, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proux01 @JasonGross