This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Upgrade minimum Vagrant version from 1.1 to 1.5 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,5 @@ | |||
| language: ruby | |||
| rvm: | |||
| - 1.9.3 | |||
There was a problem hiding this comment.
Vagrant comes with an embedded Ruby. I believe it's been 2.0 since Vagrant 1.4.0.
|
This may fix:
Those issues were related to retry logic for communicators (winrm or ssh). This PR replaces legacy code to wait for a communicator with the built-in WaitForCommunicator action. I think the built-in action may be smarter about when to fail fast and when to keep retrying. |
|
|
||
| The default configuration of the RHEL family of Linux distributions requires a tty in order to run sudo. Vagrant does not connect with a tty by default, so you may experience the error: | ||
| The default configuration of the RHEL family of Linux distributions requires a tty in order to run sudo.Vagrant does not connect with a tty by default, so you may experience the error: |
There was a problem hiding this comment.
"sudo.Vagrant" 👈 Missing a space here. 💅
maxlinc
changed the title
smashwilson
added a commit
that referenced
this pull request
Jan 14, 2015
Upgrade minimum Vagrant version from 1.1 to 1.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@smashwilson / @mdarby
WIP but ready for review. I want to get your review and feedback on the changes so far, but check w/ me before merging so I can do one last review and cleanup.
Fixes #125.