Feat/add rest template #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String serializedResponse = getSerializedResponse(bufferedReader); | ||
| issues = new ObjectMapper().readValue(serializedResponse, IssueDto[].class); | ||
| } catch (IOException e) { | ||
| ResponseEntity<String> responseEntity = restTemplate.getForEntity(URL, String.class); |
There was a problem hiding this comment.
do we want to capture this as a string? should we capture as a list of the object type we expect?
mitchellirvin
requested changes
Feb 25, 2019
There was a problem hiding this comment.
let's chat more about capturing the response object in the getForEntity call. the jackson object mapper gives us some fine grained control over deserialization, which we might lose otherwise. can we add our custom object mapper to the rest template config?
Also, let's get unit test coverage on this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds Spring RestTemplate to call the GitHub API instead of using the curl request. Resolves issue #30
Other changes: