Merge pull request #298 from mithraiclabs/bugfix/improve-mark-price-fail

Improve failure state for mark price fetch
mithraiclabs · May 2, 2021 · ddf4209 · ddf4209
2 parents 9d0c73b + 83ad0b1
commit ddf4209
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/components/pages/Markets/Markets.js b/src/components/pages/Markets/Markets.js
@@ -410,7 +410,7 @@ const Markets = () => {
             alignItems="center"
           >
             <Box>
-              {uAsset && uAsset.tokenSymbol && markPrice && (
+              {!!uAsset?.tokenSymbol && !!markPrice && (
                 <>
                   {uAsset?.tokenSymbol} Market Price: $
                   {markPrice && markPrice.toFixed(precision)}

diff --git a/src/hooks/useBonfidaMarkPrice.js b/src/hooks/useBonfidaMarkPrice.js
@@ -7,6 +7,7 @@ export const useBonfidaMarkPrice = ({ uAsset, qAsset }) => {
   const { pushNotification } = useNotifications()
 
   useEffect(() => {
+    setMarkPrice(0)
     let timer
     if (uAsset?.tokenSymbol && qAsset?.tokenSymbol) {
       const fetchPrice = async () => {
@@ -22,6 +23,9 @@ export const useBonfidaMarkPrice = ({ uAsset, qAsset }) => {
             setMarkPrice(0)
           }
         } catch (err) {
+          // Stop polling on failure to prevent error messages from popping up repeatedly
+          clearInterval(timer)
+          setMarkPrice(0)
           pushNotification({
             severity: 'error',
             message: `Couldn't load market price for ${uAsset?.tokenSymbol}`,