Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #1306

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Improve logging #1306

merged 3 commits into from
Jun 12, 2024

Conversation

aarondr77
Copy link
Member

@aarondr77 aarondr77 commented Jun 10, 2024

Description

Improves enterprise logging:

  1. Creating a separate error code for Mito sheet crashes. These are the most disruptive errors that we should prioritize fixing.
  2. Adding the error name as a parameter so you can easily differentiate between them in your dashboard. For example: add_column_failed or set_column_formula_failed.

Testing

See the new tests

Documentation

We need to update the enterprise logging docs

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 1:42pm

@aarondr77 aarondr77 changed the base branch from dev to main June 10, 2024 19:12
@naterush
Copy link
Contributor

LGTM when Python tests are passing

@aarondr77 aarondr77 merged commit 93bc7a7 into main Jun 12, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants