Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update linting #61

Merged
merged 1 commit into from
Jul 11, 2023
Merged

update linting #61

merged 1 commit into from
Jul 11, 2023

Conversation

ChristopherChudzicki
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki commented Jul 10, 2023

What are the relevant tickets?

This is a followup to #59 to fix doof publishing, which introduced an issue with peer dependency versions. Specifically:

yarn install (which we use locally and on CI) works but issues some warnings; npm install (which doof uses) was throwing an error.

What does this do?

This PR resolves some peer dependency conflicts. The result is that npm install runs without errors.

How can this be tested?

  1. On main: Run npm install (not yarn!). It will error.
  2. On this branch: Run npm install (not yarn!). It should succeed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristopherChudzicki ChristopherChudzicki merged commit 3f545fd into main Jul 11, 2023
@odlbot odlbot mentioned this pull request Jul 11, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants