use new api changes #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeglova
force-pushed
the
ab/new-search
branch
from
a8c240c
to
aaa4f46
Compare
ChristopherChudzicki
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
These changes make sense and are working well in the OCW PR.
I would still like to make the changes in https://gist.github.com/ChristopherChudzicki/fbae5f3d57b3a1b70c77d69705578e14, but I don't see any reason we can't just release this as a 3.x major version, then release those changes as a 4.x major version.
This should be a major version bump, though. 👍
abeglova
force-pushed
the
ab/new-search
branch
from
a021624
to
b2a53a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
closes mitodl/ocw-hugo-themes#1294
Description (What does it do?)
This pr updates the search to use the new open apis.
These are the course-search-utils changes necessary for mitodl/ocw-hugo-themes#1313
How can this be tested?
Follow the instructions in mitodl/ocw-hugo-themes#1313
This pr needs to be merged before the ocw-hugo-themes pr