update open-api-axios #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeglova
commented
May 6, 2024
| offset: firstNumber, | ||
| id: numbers, | ||
| free: firstBoolean, | ||
| learning_format: withinEnum(Object.values(LearningFormatEnum)) |
There was a problem hiding this comment.
Needed to make this update here because otherwise typecheck is unhappy about LearningResourcesSearchApiLearningResourcesSearchRetrieveRequest having extra parameters
ChristopherChudzicki
approved these changes
May 6, 2024
abeglova
force-pushed
the
ab/update-open-api-axios
branch
from
c9ad4d8
to
03287e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
None
Description (What does it do?)
This pr update @mitodl/open-api-axios to include new changes to the sortby parameter